Uploaded image for project: 'Quarkus'
  1. Quarkus
  2. QUARKUS-5977

[3.20] quarkus_websockets_server_connections_opened_errors_total metric doesn't increment when exception is thrown on websocket opening

XMLWordPrintable

    • False
    • Hide

      None

      Show
      None
    • False
    • +
    • Hide
      [id="ref_rn-qdocs-1163-websocket-connection-error-metrics_{context}"]
      = WebSockets Next: Connection error metrics not incremented on open event exceptions

      In {ProductLongName} {ProductVersion}, with the `websockets-next` extension, when a `@WebSocket` endpoint throws an exception in the `@OnOpen` lifecycle method, the following metrics are not incremented:

      * `quarkus_websockets_server_connections_opened_errors_total{uri=${ENDPOINT}}`
      * `quarkus_websockets_client_connections_opened_errors_total{uri=${ENDPOINT}}`

      This behavior affects both server-side and client-side WebSocket connection metrics.

      Workaround: No workaround is available at this time.
      This issue is planned to be resolved in a future release.

      For more information, see link:https://issues.redhat.com/browse/QUARKUS-5977[QUARKUS-5977].
      Show
      [id="ref_rn-qdocs-1163-websocket-connection-error-metrics_{context}"] = WebSockets Next: Connection error metrics not incremented on open event exceptions In {ProductLongName} {ProductVersion}, with the `websockets-next` extension, when a `@WebSocket` endpoint throws an exception in the `@OnOpen` lifecycle method, the following metrics are not incremented: * `quarkus_websockets_server_connections_opened_errors_total{uri=${ENDPOINT}}` * `quarkus_websockets_client_connections_opened_errors_total{uri=${ENDPOINT}}` This behavior affects both server-side and client-side WebSocket connection metrics. Workaround: No workaround is available at this time. This issue is planned to be resolved in a future release. For more information, see link: https://issues.redhat.com/browse/QUARKUS-5977 [ QUARKUS-5977 ].
    • Hide 
      git clone git@github.com:quarkus-qe/quarkus-test-suite.git --branch 3.20 && cd quarkus-test-suite
./mvnw clean verify -pl websockets/websocket-next -Dit.test=OpenShiftWebSocketsNextMetricsIT#serverErrorMetricsTest
      Show
      git clone git@github.com:quarkus-qe/quarkus-test-suite.git --branch 3.20 && cd quarkus-test-suite ./mvnw clean verify -pl websockets/websocket-next -Dit.test=OpenShiftWebSocketsNextMetricsIT #serverErrorMetricsTest
    • ---

      Websocket.next endpoint throwing exception on opening of connection doesn't increment count of quarkus_websockets_server_connections_opened_errors_total{uri=${ENDPOINT}} metric counter.

      For example, I have a following websocket:

      @WebSocket(path = "/failing")
public class FailingWebsocket {
    @OnOpen()
    public void onOpen() {
        throw new RuntimeException("Websocket failed to open");
    }
.
.
.
}

      But opening a connection on it doesn't increment the counter. Same happens for the quarkus_websockets_client_connections_opened_errors_total{uri=${ENDPOINT}} counter.

              gandrian Georgios Andrianakis
              mjurc@redhat.com Michal Jurc
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated: