Uploaded image for project: 'Quarkus'
  1. Quarkus
  2. QUARKUS-4851

Bump com.fasterxml.jackson:jackson-bom from 2.17.0 to 2.17.1

XMLWordPrintable

    • Icon: Component Upgrade Component Upgrade
    • Resolution: Obsolete
    • Icon: Major Major
    • 3.8.6.GA
    • None
    • team/eng

      This pull request bump Jackson from 2.17.0 to 2.17.1 replacing this [automatically generated one](https://github.com/quarkusio/quarkus/pull/40569).

      In this release Jackson changed the default `RecyclerPool` implementation ( see https://github.com/FasterXML/jackson-core/commit/2a4a6dc908284d94c55b5b62ba114d0e25434cea ) because of [some problems](https://github.com/FasterXML/jackson-core/issues/1260) we found in the `LockFree` version. At the moment they decided to revert back to the ThreadLocal-based implementation, the non-friendly one for virtual thread, so very likely this will be changed again in the near future.

      For this reason I believe that the test checking for the default pool implementation currently in use by Jackson, that has been introduced with [this commit](https://github.com/quarkusio/quarkus/commit/982fdb856c845d4bfbe88d630857dda6de17305a), is brittle and I removed it. That test was necessary to check that the `VertxHybridPoolObjectMapperCustomizer` was behaving as expected, replacing the `RecyclerPool` implementation only when the user hasn't explicitly configured a pool that is different from the default one. I changed the `VertxHybridPoolObjectMapperCustomizer` so that it now compares the `RecyclerPool` implementation in use with the Jackson's default one, thus making the test that I removed no longer necessary.

      As a side note it seems odd to me that Quarkus uses a version of `jackson-core` that is different from the one used by Vert.x, which is still depending on Jackson 2.16.1. Is this expected?

      /cc @franz1981 @gsmet @vietj @geoand

            Unassigned Unassigned
            olubyans@redhat.com Alexey Loubyansky
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: