Uploaded image for project: 'Quarkus'
  1. Quarkus
  2. QUARKUS-2893

Normalize uri template name to be a valid regex groupname

XMLWordPrintable

      See https://github.com/quarkusio/quarkus/issues/25258#issuecomment-1113714298 for a description of what is allowed in a uri template.

      These changes add support for `_-.\d` in the component's name.

      Previosly, the component name was directly used as a capture group name.
      The above mentioned characters however are not allowed at some positions in groupnames however.

      Therefore I added a simple normalization, making sure the component name only contains characters in the range `A-Za-z0-9`.

      Also, I added support for spaces in before and after the name, and before and after the regex part.
      The ABNF (see comment above) allows WSP in these cases, which is 0x09 (HTAB) or 0x20 (SPACE). I don't believe however that tabs are that often used inside an `@Path`.

      fixes #25258

            [QUARKUS-2893] Normalize uri template name to be a valid regex groupname

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Important: Red Hat build of Quarkus 2.7.7 release and security update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2023:1006

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Important: Red Hat build of Quarkus 2.7.7 release and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:1006

            Fedor Dudinskii added a comment -

            Verified for 2.7.7.CR1:
            baremetal JVM: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/rhbq-2.7-rhel8-jdk11-baremetal-ts-jvm/jdk=openjdk-11,label=RHEL8%20&&%20large,scenario=http-modules/54/consoleFull
            baremetal Native: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/rhbq-2.7-rhel8-jdk11-baremetal-ts-native/jdk=openjdk-11,label=RHEL8%20&&%20xlarge,scenario=http-modules/9/consoleFull
            OCP JVM: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/rhbq-2.7-rhel8-jdk11-openshift-ts-jvm-ocp-4-stable/jdk=openjdk-11,label=RHEL8%20&&%20medium,scenario=http-modules/33/consoleFull
            OCP Native: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/rhbq-2.7-rhel8-jdk11-openshift-ts-native-ocp-4-stable/jdk=openjdk-11,label=RHEL8%20&&%20xlarge,scenario=http-modules/20/consoleFull

            Fedor Dudinskii added a comment - Verified for 2.7.7.CR1: baremetal JVM: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/rhbq-2.7-rhel8-jdk11-baremetal-ts-jvm/jdk=openjdk-11,label=RHEL8%20&&%20large,scenario=http-modules/54/consoleFull baremetal Native: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/rhbq-2.7-rhel8-jdk11-baremetal-ts-native/jdk=openjdk-11,label=RHEL8%20&&%20xlarge,scenario=http-modules/9/consoleFull OCP JVM: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/rhbq-2.7-rhel8-jdk11-openshift-ts-jvm-ocp-4-stable/jdk=openjdk-11,label=RHEL8%20&&%20medium,scenario=http-modules/33/consoleFull OCP Native: https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/job/rhbq-2.7-rhel8-jdk11-openshift-ts-native-ocp-4-stable/jdk=openjdk-11,label=RHEL8%20&&%20xlarge,scenario=http-modules/20/consoleFull

            Rostislav Svoboda added a comment -

            TD: https://github.com/quarkus-qe/quarkus-test-suite/pull/1031

            Rostislav Svoboda added a comment - TD: https://github.com/quarkus-qe/quarkus-test-suite/pull/1031

              Unassigned Unassigned
              probinso_jira Quarkus JIRA Bot (Inactive)
              Rostislav Svoboda Rostislav Svoboda
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: