Uploaded image for project: 'Quarkus'
  1. Quarkus
  2. QUARKUS-1343

Quarkus BOM includes junit dependency

    XMLWordPrintable

Details

    • +

    Description

      Quarkus BOM should not include the junit dependency:

            <dependency>
              <groupId>junit</groupId>
              <artifactId>junit</artifactId>
              <version>4.11</version>
            </dependency>
      

      This is hardcoding the junit version to 4.11 when some users might need 4.13.

      We have found this issue by running the quickstart repo:

      mvn clean verify -pl kogito-dmn-quickstart -Dquarkus.platform.group-id=com.redhat.quarkus.platform -Dquarkus.platform.artifact-id=quarkus-bom -Dquarkus.platform.version=2.2.3.Final-redhat-00013 -Dquarkus-plugin.version=2.2.3.Final-redhat-00013
      

      It will fail with:

      [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project kogito-dmn-quickstart: There are test failures.
      [ERROR] 
      [ERROR] Please refer to /home/jcarvaja/sources/quarkus-quickstarts/kogito-dmn-quickstart/target/surefire-reports for the individual test results.
      [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
      [ERROR] There was an error in the forked process
      [ERROR] TestEngine with ID 'junit-vintage' failed to discover tests
      [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
      [ERROR] TestEngine with ID 'junit-vintage' failed to discover tests
      [ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:733)
      [ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:305)
      

      Using the 2.2.2.Final upstream version, it works fine:

      mvn clean verify -pl kogito-dmn-quickstart -Dquarkus.platform.group-id=io.quarkus -Dquarkus.platform.artifact-id=quarkus-bom -Dquarkus.platform.version=2.2.3.Final -Dquarkus-plugin.version=2.2.3.Final
      

      Removing the junit dependency from "com.redhat.quarkus.platform:quarkus-bom" will fix this issue.

      Attachments

        Activity

          People

            hamadhan@redhat.com Harsh Madhani
            jcarvaja@redhat.com Jose Carvajal Hilario
            Fedor Dudinskii Fedor Dudinskii
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: