Uploaded image for project: 'Project Quay'
  1. Project Quay
  2. PROJQUAY-9446

Quay fails to start when auth type is OIDC and Google is the only auth provider

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • quay-v3.15.0
    • quay
    • False
    • Hide

      None

      Show
      None
    • False
    • Quay Enterprise

      Traceback (most recent call last):
        File "/quay-registry/conf/init/data_migration.py", line 4, in <module>
          from app import app
        File "/quay-registry/app.py", line 274, in <module>
          authentication = UserAuthentication(app, config_provider, OVERRIDE_CONFIG_DIRECTORY, oauth_login)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/quay-registry/data/users/__init__.py", line 175, in __init__
          self.state = self.init_app(app, config_provider, override_config_dir, oauth_login)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/quay-registry/data/users/__init__.py", line 181, in init_app
          users = get_users_handler(app.config, config_provider, override_config_dir, oauth_login)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/quay-registry/data/users/__init__.py", line 167, in get_users_handler
          raise RuntimeError("Unknown authentication type: %s" % authentication_type)
      RuntimeError: Unknown authentication type: OIDC
      

      Issue is caused by this function:

      https://github.com/quay/quay/blob/57915a5ef3b0065d878f51fae3bae892f9c019e9/data/users/__init__.py#L147-L166

      Google OIDC config only takes two parameters: client id and client secret. Same is true for Github auth., Github Enterprise auth also takes into account the Github URL. These parameters are insufficient, function in question requires more parameters than what we define.

              Unassigned Unassigned
              rhn-support-ibazulic Ivan Bazulic
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: