-
Task
-
Resolution: Done
-
Normal
-
omr-v1.3.10
-
False
-
None
-
False
-
-
Hi team,
What
I noticed that the current config.yaml.j2 contains some hard-coded secrets, and confirmed in an internal environment that they were unchanged as part of the mirror-registry deployment process.
Why
I believe users of mirror-registry will want unique passwords & secrets, most importantly the CSRF SECRET_KEY since that has significant implications on session hijacking.
How
- Add new task secret-vars.yaml that will generate random strings using the already imported community.general.random_string library.
- Export those secrets as facts
- Update the config.yaml.j2 to use those facts as part of deployment
- Update install-postgres-service.yaml and install-redis-service.yaml to create podman secrets using the facts
- Update postgres.service.j2 and redis.service.j2 to utilize the secrets created
This will not impact upgrades, only initial deployments.
I've done the DCO sign-off, and believe this PR is ready to merge, however I'm happy to update/modify based on feedback from this team.
Cheers,
-BadgerOps
- links to
-
RHBA-2024:129094 mirror registry for Red Hat OpenShift 1.3.11 container