Uploaded image for project: 'Project Quay'
  1. Project Quay
  2. PROJQUAY-10028

Fix pre-commit hooks failing

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • None
    • quay
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • False
    • Not Selected

       The issue is actually in the config file itself - the stages: [pre-commit] syntax was deprecated and removed in newer versions. The config needs to use stages: [commit] instead. Let me fix that. Update(.pre-commit-config.yaml)
        ⎿  Added 1 line, removed 1 line
             23            entry: bash -c 'if git diff --cached --name-only --diff-filter=A | grep -q "^web/cypress/e2e/.*\.cy\.ts$"; then echo " New Cypress tests are not allowed. Please use Playwright instead.
                   See web/playwright/MIGRATION.md"; exit 1; fi'
             24            language: system
             25            pass_filenames: false
             26 -          stages: [pre-commit]
             26 +          stages: [commit]
             27        -   id: eslint
             28            name: ESLint
             29            entry: web/node_modules/.bin/eslint --fix

              doconnor@redhat.com Dave O'Connor
              doconnor@redhat.com Dave O'Connor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: