Uploaded image for project: 'PicketLink'
  1. PicketLink
  2. PLINK-516

PicketLink AbstractIDPValve does not trigger the next valve in the pipeline

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • PLINK_2.7.0.Beta1
    • PLINK_2.6.0.Final
    • SAML
    • None
    • Sprint_July7-11,2014, Sprint_July14-25,2015
    • Hide

      Stack the ExtendedFormAuthenticator, IDPWebBrowserSSOValve and RequestDumperValve together. The RequestDumperValve will not get called.

      <jboss-web>
      <security-domain>SPNEGO</security-domain>
      <disable-audit>false</disable-audit>
      <context-root>idp</context-root>
      <valve>
      <class-name>org.jboss.as.web.security.ExtendedFormAuthenticator</class-name>
      </valve>
      <valve>
      <class-name>org.picketlink.identity.federation.bindings.tomcat.idp.IDPWebBrowserSSOValve</class-name>
      <param>
      <param-name>passUserPrincipalToAttributeManager</param-name>
      <param-value>true</param-value>
      </param>
      <param>
      <param-name>characterEncoding</param-name>
      <param-value>UTF-8</param-value>
      </param>
      </valve>
      <valve>
      <class-name>org.apache.catalina.valves.RequestDumperValve</class-name>
      </valve>
      </jboss-web>

      Show
      Stack the ExtendedFormAuthenticator, IDPWebBrowserSSOValve and RequestDumperValve together. The RequestDumperValve will not get called. <jboss-web> <security-domain>SPNEGO</security-domain> <disable-audit>false</disable-audit> <context-root>idp</context-root> <valve> <class-name>org.jboss.as.web.security.ExtendedFormAuthenticator</class-name> </valve> <valve> <class-name>org.picketlink.identity.federation.bindings.tomcat.idp.IDPWebBrowserSSOValve</class-name> <param> <param-name>passUserPrincipalToAttributeManager</param-name> <param-value>true</param-value> </param> <param> <param-name>characterEncoding</param-name> <param-value>UTF-8</param-value> </param> </valve> <valve> <class-name>org.apache.catalina.valves.RequestDumperValve</class-name> </valve> </jboss-web>

    Description

      PicketLink AbstractIDPValve does not trigger the next valve in the pipeline. The invoke() method of the AbstractIDPValve does not call getNext().invoke() which means that the pipeline processing will always terminate with the IDP valve.

      You can see this by placing the AccessLogValve after the IDP valve in the WEB-INF/jboss-web.xml file. The AccessLogValve will not get triggered.

      Attachments

        Issue Links

          relates to

          Bug - A problem that impairs or prevents the functions of the product. PLINK-558 AbstractIDPValve should always invoke next valve

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Activity

            People

              psilva@redhat.com Pedro Igor Craveiro
              rhn-support-dehort Derek Horton
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: