Uploaded image for project: 'Observability UI'
  1. Observability UI
  2. OU-416

When custom datasource is not found it should not fallback to the default in cluster prometheus

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • OpenShift 4.16
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • NEW
    • NEW
    • Before this fix, if a custom datasource defined on a dashboard was not found the data was fetched from the default datasource. After the fix, an error is displayed instead.
    • Bug Fix
    • Sprint 252, Sprint 253

      when using the monitoring plugin with the console dashboards plugin, if a custom datasource defined in a dashboard is not found, the default in cluster prometheus is used to fetch data. This creates a false assumption to the user that the custom dashboard is working when in reality, it should fail.

       

      How to reproduce:

      • In OpenShift 4.16
      • Install COO
      • Enable the console dashboards plugin as documented here
      • Create a dashboard that uses custom datasources as documented here. Do not create a datasource so the bug can be reproduced
      • Go to monitoring -> dashboards and select the dashboard created above

      Expected result

      The dashboard should display an error as the custom datasource was not found

            [OU-416] When custom datasource is not found it should not fallback to the default in cluster prometheus

            Junqi Zhao added a comment - - edited

            checked with 4.16.0-0.nightly-2024-05-07-025557, created dashboard has a reference to custom data source which the data source does not exist, there is error "Error loading card" on dashboard, the data come from the custom datasource not from thanos

            Junqi Zhao added a comment - - edited checked with 4.16.0-0.nightly-2024-05-07-025557, created dashboard has a reference to custom data source which the data source does not exist, there is error "Error loading card" on dashboard, the data come from the custom datasource not from thanos

            Gabriel Bernal added a comment -

            juzhao@redhat.com the datasource should be defined as a JSON object as documented here. I added some instructions on how to reproduce

            Gabriel Bernal added a comment - juzhao@redhat.com the datasource should be defined as a JSON object as documented here. I added some instructions on how to reproduce

            Junqi Zhao added a comment - - edited

            gbernal@redhat.com tested on 4.16.0-0.nightly-2024-05-05-102537, created dashboard with workload.yaml file in https://drive.google.com/drive/folders/1DuTtkYiFqAOQxKQ_Z0AfJa9vWvvQpbMo?usp=drive_link

            the "datasource" is "recent" which does not exist, did not see error for the dashboard, anything I am wrong with the testing?

            Junqi Zhao added a comment - - edited gbernal@redhat.com tested on 4.16.0-0.nightly-2024-05-05-102537, created dashboard with workload.yaml file in https://drive.google.com/drive/folders/1DuTtkYiFqAOQxKQ_Z0AfJa9vWvvQpbMo?usp=drive_link the "datasource" is "recent" which does not exist, did not see error for the dashboard, anything I am wrong with the testing?

              gbernal@redhat.com Gabriel Bernal
              gbernal@redhat.com Gabriel Bernal
              Junqi Zhao Junqi Zhao
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: