-
Story
-
Resolution: Unresolved
-
Normal
-
None
-
None
-
None
-
None
-
False
-
None
-
False
-
-
-
OTA 263
We currently do not run existing SLO tests in the Cincinnati CI.
This is unfortunate, as they have the potential to warn us about regressions that could otherwise go undetected (e.g., performance degradation). It would be beneficial to turn on these tests again. However, some of the tests would not pass at the moment, it seems.
I have run a CI test run, which had the SLO tests enabled, to look at the SLO tests results. Some of the tests currently do not pass.
running 12 tests test check_slo_numeric::only_http_4xx_errors_returned ... ok test check_slo_parameter::graph_builder_returns_build_information ... ok test check_slo_exact::no_scrape_errors ... ok test check_slo_parameter::policy_engine_returns_build_information ... ok test check_slo_exact::crashes_due_to_liveness_checks ... ok test check_slo_numeric::at_least_one_scrape_has_been_performed ... ok test check_slo_exact::no_upstream_errors ... ok test check_slo_exact::crashes_due_to_oom_killer ... ok test check_slo_exact::no_gb_pe_restarts ... FAILED test check_slo_float::_90_of_requests_are_served_in_0_5_sec ... FAILED test check_slo_exact::crashes_due_to_process_exit_code ... FAILED test check_slo_float::osus_can_handle_at_least_100rps ... FAILED
Definition of Done:
- Failing SLO tests are investigated.
- If a test is no longer relevant, it can be dropped.
- If a test is easily fixable, the test is fixed.
- Otherwise, the test is set to be ignored if applicable, and a new card is created for the test.
- SLO tests are enabled as part of the e2e test.
- is related to
-
-
- Closed
-