Uploaded image for project: 'OpenShift Service Mesh'
  1. OpenShift Service Mesh
  2. OSSM-6295

[IOR] Copy `argocd.argoproj.io` annotations and labels from Gateways to Routes except `argocd.argoproj.io/instance`

XMLWordPrintable

      Some time ago we accepted 2 PRs made by our users:
      1) Fix IOR wrongly copying argocd internal annotation from Gateway to route
      2) Fix IOR wrongly copying argocd label from Gateway to route

      These PRs were intented to fix the following issue:

      When IOR creates a route from a Gateway, it copies annotations and labels, including the ones managed by argoCD.
      As a consequence, when deploying the Gateway with argocd, the argocd.argoproj.io/instance label (used by argoCD to track the objects it manages) is copied in the route. From this point ArgoCD constantly deletes the route (since it is not part of the desired manifest). This makes it impossible to deploy Gateway with argoCD, unless IOR automatic route creation is disabled.

      Instead of not copying all annotations and labels with prefix `argocd.argoproj.io`, we should not copy only the problematic label `argocd.argoproj.io/instance`.

            jewertow@redhat.com Jacek Ewertowski
            jewertow@redhat.com Jacek Ewertowski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: