Uploaded image for project: 'OpenShift Service Mesh'
  1. OpenShift Service Mesh
  2. OSSM-6153

Fix error handling around updateStatus()

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • OSSM 3.0-TP1
    • None
    • Project Sail
    • None

      The error handling in and around the updateStatus() function in all three controllers looks suspicious and is also hard to understand. We should refactor it and solve any bugs that become apparent during the refactor.

      For example, the updateStatus function takes the reconcile error as an argument. Sometimes, it returns this error, and sometimes it doesn't. It should probably only return an error when a new error occurs within the function itself. It should not return the reconcile error that was passed in. Instead, the caller should handle the four possible combinations of (reconcileError, statusError).

            mluksa@redhat.com Marko Luksa
            mluksa@redhat.com Marko Luksa
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: