Uploaded image for project: 'OpenShift Service Mesh'
  1. OpenShift Service Mesh
  2. OSSM-5319

Clean up chart rendering

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Undefined Undefined
    • Sail MVP2
    • None
    • Sail Operator
    • None
    • Sprint 13

      When rendering charts, the Sail operator (always) sets the following values (in maistra_30_strategy.go):

      • global.istioNamespace
      • istio_cni.enabled
      • cni.privileged

      The operator assumes that CNI should always be enabled, but this is wrong. Since the operator is meant to be moved upstream, it should support deploying the Istio control plane in any way the user wants.

      Additionally, the name (maistra_30_strategy) no longer makes sense, since there is no "3.0" Istio version.

      We should remove the code that sets the istio_cni.enabled and cni.privileged values, and move the code that sets global.istioNamespace somewhere else. Also, users shouldn't be able to override the namespace. It must always match the namespace of the Istio resource.

              mluksa@redhat.com Marko Luksa
              mluksa@redhat.com Marko Luksa
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: