Uploaded image for project: 'OpenShift Service Mesh'
  1. OpenShift Service Mesh
  2. OSSM-3936

[kiali] do not hardcode label names

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • OSSM 2.4.1
    • None
    • Kiali
    • None

      https://github.com/kiali/kiali/blob/v1.67.0/business/mesh.go#L603

          pendingNss, err := in.k8s.GetNamespaces("istio-injection=enabled")

      This should not be hardcoded. That label can be customized: https://github.com/kiali/kiali/blob/v1.67.0/config/config.go#L639

      Same thing here: https://github.com/kiali/kiali/blob/v1.67.0/business/mesh.go#L611

          pendingNss, err = in.k8s.GetNamespaces(fmt.Sprintf("istio.io/rev=%s", current))

      That label can be customized here: https://github.com/kiali/kiali/blob/v1.67.0/config/config.go#L640

            [OSSM-3936] [kiali] do not hardcode label names

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Moderate: Red Hat OpenShift Service Mesh Containers for 2.4.1 security update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2023:4114

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Moderate: Red Hat OpenShift Service Mesh Containers for 2.4.1 security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:4114

            Jay Shaughnessy added a comment -

            Yes, consider as verified.

            Jay Shaughnessy added a comment - Yes, consider as verified.

            Filip Brychta added a comment -

            Hi jshaughn@redhat.com this ticket is in Release Pending and I don't see any testing notes. Can we consider this as verified just by running kiali automation?

            Filip Brychta added a comment - Hi jshaughn@redhat.com this ticket is in Release Pending and I don't see any testing notes. Can we consider this as verified just by running kiali automation?

              rhn-engineering-jshaughn Jay Shaughnessy
              jmazzitelli John Mazzitelli
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: