Uploaded image for project: 'OpenShift Service Mesh'
  1. OpenShift Service Mesh
  2. OSSM-3936

[kiali] do not hardcode label names

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Undefined
    • OSSM 2.4.1
    • None
    • Kiali
    • None

    Description

      https://github.com/kiali/kiali/blob/v1.67.0/business/mesh.go#L603

          pendingNss, err := in.k8s.GetNamespaces("istio-injection=enabled")

      This should not be hardcoded. That label can be customized: https://github.com/kiali/kiali/blob/v1.67.0/config/config.go#L639

      Same thing here: https://github.com/kiali/kiali/blob/v1.67.0/business/mesh.go#L611

          pendingNss, err = in.k8s.GetNamespaces(fmt.Sprintf("istio.io/rev=%s", current))

      That label can be customized here: https://github.com/kiali/kiali/blob/v1.67.0/config/config.go#L640

      Attachments

        Activity

          People

            rhn-engineering-jshaughn Jay Shaughnessy
            jmazzitelli John Mazzitelli
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: