Uploaded image for project: 'OpenShift Service Mesh'
  1. OpenShift Service Mesh
  2. OSSM-3803

Move extensionProviders to SMCP.spec.meshConfig.extensionProviders

    • Icon: Task Task
    • Resolution: Done
    • Icon: Undefined Undefined
    • OSSM 2.4.0
    • None
    • Maistra
    • None

      The extensionProviders field is currently directly in SMCP.spec. In upstream, this field is under meshConfig. We're now also adding the discoverySelectors field from meshConfig.

      If we end up adding other fields, the SMCP.spec may become disorganized. Also, if we end up supporting the full meshConfig field, we'll most likely expose it as SMCP.spec.meshConfig. So, we'll end up with two locations where users can specify extensionProviders or discoverySelectors - in the SMCP.spec directly, and within SMCP.spec.meshConfig. To prevent this, it makes sense to create the SMCP.spec.meshConfig field now, but have it contain only extensionProviders and discoverySelectors. If we later support other meshConfig fields, we can add them here. And if we decide to support the entire meshConfig, we'll end up with a clean SMCP spec with no duplication.

            [OSSM-3803] Move extensionProviders to SMCP.spec.meshConfig.extensionProviders

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (Important: Red Hat OpenShift Service Mesh Containers for 2.4.0), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHSA-2023:3644

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (Important: Red Hat OpenShift Service Mesh Containers for 2.4.0), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:3644

            Tested these changes against the 2.4 build, test case passed successfully. 

            Praneeth Bajjuri added a comment - Tested these changes against the 2.4 build, test case passed successfully. 

              mluksa@redhat.com Marko Luksa
              mluksa@redhat.com Marko Luksa
              Praneeth Bajjuri
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: