Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-9991

ValidateCertSecrets miss return information on which cert secret is missing

XMLWordPrintable

    • Moderate

      https://github.com/openstack-k8s-operators/lib-common/pull/547 fixed an issue where the problem was that you can't return a non-standard requeue ctrlResult and an error at the same time, because the requeue will be ignored and the error is handled instead – which means the next reconcile loop will not happen when you have requested.

      This lead to the situation that when calling tls.ValidateCertSecrets() from the service operators the information about which of the endpoint services secret is missing is not available.

      After a discussion on slack we decided to update ValidateCertSecrets to return an error instead of ctrlResult in case the cert secret is missing. With this the caller has the information on what secret is missing and then can decide what to do. In most cases we do not have to schedule a reconcile since the service operators chanced to watch the named cert secret resources. 

              rhn-support-mschuppe Martin Schuppert
              rhn-support-mschuppe Martin Schuppert
              rhos-dfg-ospk8s
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: