Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-3200

[ovn-operator] Name of the config job can be too long and cause crash of the ovn controller

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major Major
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • ?
    • ?
    • OSPRH-811 - Red Hat OpenStack 18.0 Greenfield Deployment
    • ?
    • ?
    • None
    • Important

      Name of the Job in OCP have 63 chars limit and if hostname of the worker node where ovn config job is running is long enough, it may case crash of the ovncontroller controller. Error is then like:
        * [stack@director ~]$ oc logs ovn-operator-controller-manager-857ffcb767-vlczv | tail -50

      • /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:329
      • sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
      • /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274
      • sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
      • /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235
      • 2023-10-17T14:30:35.914Z INFO controllers.OVNController Reconciling Service
      • 2023-10-17T14:30:35.916Z INFO controllers.OVNController Reconciling Service init
      • 2023-10-17T14:30:35.916Z INFO controllers.OVNController Reconciled Service init successfully
      • 2023-10-17T14:30:35.916Z INFO controllers.OVNController Reconciling Service update
      • 2023-10-17T14:30:35.916Z INFO controllers.OVNController Reconciled Service update successfully
      • 2023-10-17T14:30:35.916Z INFO controllers.OVNController Reconciling Service upgrade
      • 2023-10-17T14:30:35.916Z INFO controllers.OVNController Reconciled Service upgrade successfully
      • 2023-10-17T14:30:35.935Z INFO controllers.OVNController DaemonSet: updated {"ObjectType": "*v1.DaemonSet", "ObjectNamespace": "openstack", "ObjectName": "ovn-controller"}
      • 2023-10-17T14:30:35.941Z ERROR controllers.OVNController Job CreateOrPatch failed {"job": "ovncontroller-configuration-10-37-140-124.rhev.lab.eng.brq2.redhat.com", "error": "Job.batch \"ovncontroller-configuration-10-37-140-124.rhev.lab.eng.brq2.redhat.com\" is invalid: spec.template.labels: Invalid value: \"ovncontroller-configuration-10-37-140-124.rhev.lab.eng.brq2.redhat.com\": must be no more than 63 characters"}
      • github.com/openstack-k8s-operators/lib-common/modules/common/job.(*Job).createJob
      • /go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/common@v0.3.1-0.20231006072650-7fe7fe16bcd1/job/job.go:82
      • github.com/openstack-k8s-operators/lib-common/modules/common/job.(*Job).DoJob
      • /go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/common@v0.3.1-0.20231006072650-7fe7fe16bcd1/job/job.go:175
      • github.com/openstack-k8s-operators/ovn-operator/controllers.(*OVNControllerReconciler).reconcileNormal
      • /remote-source/controllers/ovncontroller_controller.go:483
      • github.com/openstack-k8s-operators/ovn-operator/controllers.(*OVNControllerReconciler).Reconcile
      • /remote-source/controllers/ovncontroller_controller.go:181
      • sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
      • /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:122
      • sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
      • /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:323
      • sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
      • /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274
      • sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
      • /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235
      • 2023-10-17T14:30:35.942Z ERROR controllers.OVNController Failed to configure OVN controller {"error": "Job.batch \"ovncontroller-configuration-10-37-140-124.rhev.lab.eng.brq2.redhat.com\" is invalid: spec.template.labels: Invalid value: \"ovncontroller-configuration-10-37-140-124.rhev.lab.eng.brq2.redhat.com\": must be no more than 63 characters"}
      • github.com/openstack-k8s-operators/ovn-operator/controllers.(*OVNControllerReconciler).reconcileNormal

      This bug was found by kthakre@redhat.com during Adoption Hackathon.

              Unassigned Unassigned
              skaplons@redhat.com Slawomir Kaplonski
              rhos-dfg-networking-squad-neutron
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: