XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • infra-operator
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • 2024Q1

      As part of the controller-runtime v0.16 update. We also need to be using a version of Go > 1.20:

      ❯ go1.19.3 vet ./...
      # sigs.k8s.io/controller-runtime/pkg/cache
      ../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/cache/cache.go:412:58: fields.Selector does not implement comparable
      ../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/cache/cache.go:442:20: fields.Selector does not implement comparable
      note: module requires Go 1.20 

      vs with go 1.20 we can see it passes:

      ❯ go1.20.3 vet ./... 

      We can instead upgrade to Go 1.21, but this will require also adding Go 1.21 to the OpenShift CI environment:
      https://github.com/openshift/release/blob/master/ci-operator/config/openstack-k8s-operators/openstack-k8s-operators-ci/openstack-k8s-operators-openstack-k8s-operators-ci-main.yaml#L19-L51

              rhn-support-bshephar Brendan Shephard (Inactive)
              rhn-support-bshephar Brendan Shephard (Inactive)
              rhos-dfg-df
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: