Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-22189

The MetricStorage CR should default the networkAttachment to include the default dataplaneNetwork as that is always required for edpm connectivity

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • rhos-18.0.6
    • telemetry-operator
    • None
    • Observability Sprint 25
    • 1
    • Low

      in our default ci env the ctlplane network is routable via the pods on crc by default
      but this is not true in general and we cant assume that will be the case in a customer env

      in https://issues.redhat.com/browse/OSPRH-11017 the ablity to pass network attachment was intoduced in the teh metricsStroage CRD but it was not defualted to include the ctlplane network even though that is always requried for metics to be scraped form edpm nodes.

      in 18 we do not supprot disabling network isolation and require the ctrlplane network to deploy edpm nodes as teh only requried network so its safe to defaullt the CRD to include it

      this will remove the need to manually set this in the openstack control plane CR for all deployments.

      the fix is simple change 

       

      https://github.com/openstack-k8s-operators/telemetry-operator/blob/683f5ca02d7732bd784b72f26e2dae8db7df6f17/api/v1beta1/metricstorage_types.go#L93-L96

      form 

       

          // NetworkAttachments is a list of NetworkAttachment resource names to expose the services to the given network
          // +kubebuilder:validation:Optional
          // +listType=atomic
          NetworkAttachments []string `json:"networkAttachments,omitempty"`

       

      to 

          // NetworkAttachments is a list of NetworkAttachment resource names to expose the services to the given network
          // +kubebuilder:validation:Optional
          // +listType=atomic
          //+kubebuilder:default=["ctlplane"]
          NetworkAttachments []string `json:"networkAttachments,omitempty"`

      to match the default of DataplaneNetwork

       

          // DataplaneNetwork defines the network that will be used to scrape dataplane node_exporter endpoints
          // +kubebuilder:validation:Optional
          // +kubebuilder:default=ctlplane
          DataplaneNetwork *infranetworkv1.NetNameStr `json:"dataplaneNetwork"`

       

      this remove the need to document overriding the default to have a fucntional deploy in

      https://docs.redhat.com/en/documentation/red_hat_openstack_services_on_openshift/18.0/html-single/deploying_red_hat_openstack_services_on_openshift/index#proc_creating-the-control-plane_controlplane

              rhn-engineering-vimartin Victoria Martinez de la Cruz
              smooney@redhat.com Sean Mooney
              rhos-conplat-observability
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: