Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-22147

Reboot flag setting logic in bootc deployments is incorrect

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • edpm-ansible
    • None
    • RHOS Upgrades 2025 Sprint 17
    • 1
    • Low

      To Reproduce Steps to reproduce the behavior:

      The logic in edpm-ansible uses 'bootc switch' return code to tell whether it should create a reboot-required flag: https://github.com/openstack-k8s-operators/edpm-ansible/blob/ab5197732ee36aec11b5ac99a16d1640d3b27e17/roles/edpm_update_system/tasks/bootc.yml#L18-L40 

      This is incorrect because 'bootc switch' will return 0 both on a successful switch, but also if there is nothing to do. Essentially the reboot flag will always get set regardless if we need to reboot or not.

      Expected behavior

      • Only set the reboot flag if reboot is needed (a bootc deployment is staged).

      Bug impact

      • Bootc deployments incorrectly signal that a reboot is needed when in fact it may not be needed.

      Known workaround

      • Instead of following the reboot-required flag, look at 'bootc status' and see if there is any deployment staged.

              jstransk@redhat.com Jiri Stransky
              jstransk@redhat.com Jiri Stransky
              Ashish Oli
              rhos-dfg-upgrades
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: