https://docs.redhat.com/en/documentation/red_hat_openstack_services_on_openshift/18.0/html-single/adopting_a_red_hat_openstack_platform_17.1_deployment/index

• General:
    - The documentation runs shell scripts on the RHOSO 18 provisioning node, and presumes
      that some files from the RHOSO 17 undercloud are also available on the provisioning node.
      If files should be copied over, they should spell that out (or make it part of the script).
      (example is the triploe passwords).
    - There are lots of places where the "copy" link copies different data than what is displayed
      (e.g. only the first line, or sometimes duplication of lines).

• Section 1.7 describes creating the CRs, but doesn't mention applying them. They MUST be applied
    in order for the steps in section 3 to succeed
• Section 1.7.3.1  NodeNetworkConfigurationPolicy CR is syntactically incorrect:
    * two different API versions ("v1" and "nmstate.io/v1")
    * kind needs to be at top level
    * items isn't needed
• Section 1.10 - there is no package found (need to add repos?):
    dnf install -y golang-github-openstack-k8s-operators-os-diff

• Section 3.1, prerequisite 2, it has this:
      $ CONTROLLER1_SSH="ssh -i <path to SSH key> root@<node IP>"
    There is no mention about adding passwordless SSH from the OCP provisioning node to the RHOSP17.1
    overcloud nodes.
• Section 3.1 - it looks like steps 1-5 are just showing pieces of the overall script
    provided in step 6? They do use different mariadb client commands/scripts, but I don't
    see what they're doing differently, as they are (re-)setting the same environment variables.

• Section 3.1, step 2, the run_mysqlcheck function should use $1 instead of $CELL for the statement:
      ... SOURCE_MARIADB_IP[$CELL] ... SOURCE_DB_ROOT_PASSWORD[$CELL]

• Section 3.1, step 6 creates a shell script that runs openshift control plane commands,
    and ssh's into the RHOSP17.1 overcloud nodes. There is no mention of needing the public
    key for passwordless ssh to the RHOSP17.1 overcloud nodes from the RHOSO 18 provisioning node
    (although this comment is the same as above)

• Section 3.5, step 2:
    shell script uses a for loop, which they complete with an "end" statement, but it should be "done"

• Section 3.5, step 3:
    The shell script has this:
       $ test -z "$PULL_OPENSTACK_CONFIGURATION_MYSQLCHECK_NOK"  || [ "x$PULL_OPENSTACK_CONFIGURATION_MYSQLCHECK_NOK" = "x " ] && echo "OK" || echo "CHECK FAILED"
    However, the shell variable is an array, so the test -z check doesn't work, failing with:
       "PULL_OPENSTACK_CONFIGURATION_MYSQLCHECK_NOK: unbound variable"
    It seems like this should be moved into the for loop and checked with the array variable

• Section 5.2 mentions pre-requisites::
    "You have configured the Ceph back end for the NovaLibvirt service. For more information, see Configuring a Ceph back end."
    However, Ceph isn't manadatory.