Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-17593

Fix eventlet hubs usage in ironic/console/websocketproxy.py

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • openstack-ironic
    • None
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • rhos-ops-day1day2-hardprov
    • HardProv Sprint 7
    • 1

      Goal: 

      • As a developer, I need to remove eventlet to maintain compatibility. As such, the VNC console service support recently added to Ironic leverages evenetlet.hubs. This appears limited to ensure the thread doesn’t start attached to a thread state with an active epoll. This should not be an issue once the monkeypatching has been removed.

      Context:

      ironic/console/websockify.py imports eventlet.hubs around line 118 and then immediately calls the use_hub() call with a note to try to prevent sharing fd or parents with sibling green threads.

      **

      Once the eventlet monkey patch is removed, this should no longer be required and should just function fine as real threads will then be used.

       

      Acceptance Criteria:

      • Eventlet usage has been removed
      • Basic sanity checking performed by developer removing the code that this service is continuing to function with the eventlet monkeypatching and eventlet.hubs.use_hub() invocation removed.
      • Passes CI and is merged.

              jkreger@redhat.com Julia Kreger
              jkreger@redhat.com Julia Kreger
              rhos-dfg-hardprov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: