Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-17457

OpenStackDataPlaneService overrides labels, conflicting with management tool such as ArgoCD

XMLWordPrintable

    • False
    • Hide

      None

      Show
      None
    • False
    • ?
    • rhos-ops-day1day2-edpm
    • None
    • EDPM Sprint 5, EDPM Sprint 6, EDPM Sprint 7, EDPM Sprint 8, EDPM Sprint 9, EDPM Sprint 10, EDPM Sprint 11
    • 7
    • Moderate

      The following block overrides any existing label without checking if they may exist beforehand:
      https://github.com/openstack-k8s-operators/openstack-operator/blob/a7ebf5eb68568b0d2c1ca815ef8150a67176ec25/apis/dataplane/v1beta1/openstackdataplaneservice_types.go#L155-L161

      It was introduced with https://github.com/openstack-k8s-operators/openstack-operator/commit/deece384421a55a29a2c5299b4d7b3f32fb13377

      It conflicts with management tools such as ArgoCD, especially the app.kubernetes.io/instance label.

      This label is used by default in ArgoCD to track resources within an Application. We can of course update ArgoCD configuration to use another label, but it would require re-deploying everything, and if an admin has other resources managed by the same ArgoCD instance, it would lead to many issues.

      It may be good to either check if the label exists and avoid the override, or maybe create specific labels, such as app.openstack.io or something like that?

              Unassigned Unassigned
              cjeanner@redhat.com Cedric Jeanneret
              rhos-dfg-df
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: