Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-17412

Do not persist Status if Reconcile exits due to panic

XMLWordPrintable

    • Do not persist Status if Reconcile exits due to panic
    • False
    • Hide

      None

      Show
      None
    • False
    • Not Selected
    • Proposed
    • No Docs Impact
    • Done
    • Proposed
    • rhos-conplat-core-operators
    • Proposed
    • 0% To Do, 0% In Progress, 100% Done
    • Moderate

      Today we use a deferred call to always update the Status field when the Reconcile() call exits. We should consider not doing that if the Reconcile() exited due to panic, to avoid persisting potentially incorrect data.

       

      Same is fixed for nova-operator and placement-operator through below Epic.

      https://issues.redhat.com/browse/OSPRH-16687

      This looks like something that we should replicate across all our operators, as we use the same defer() pattern in all of them.

              rhn-support-ratailor Rajesh Tailor
              rhn-support-ratailor Rajesh Tailor
              Andrew Bays, Dan Prince
              rhos-workloads-compute
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 weeks
                  2w