Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-16550

Mismatch between field name and JSON tag for NodeName in BGPConfiguration spec.frrNodeConfigurationSelector.frrConfigurationNamespace

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • rhos-18.0.10 FR 3
    • rhos-18.0 FR 2 (Mar 2025)
    • infra-operator
    • None
    • 2
    • False
    • Hide

      None

      Show
      None
    • False
    • ?
    • infra-operator-container-1.0.12-2
    • rhos-ops-platform-services-pidone
    • None
    • Hide
      .NodeName string updated in JSON tag for BGPConfiguration parameter
      Before this update, the BGPConfiguration parameter `spec.frrNodeConfigurationSelector.nodename` had an inconsistency in its JSON tag where the NodeName string `json:"frrConfigurationNamespace,omitempty` was incorrect because `frrConfigurationNamespace` is a node name. With this update, the NodeName string in the JSON tag is correctly set as `json:"nodeName,omitempty"`. You can now configure the `frrNodeConfigurationSelector` by using the following spec:

      ----
          frrNodeConfigurationSelector:
          - nodeName: nodeA
            nodeSelector:
              matchLabels:
                foo: bar
      ----

      During an update to the fixed version, any node names that you previously specified by using the `frrConfigurationNamespace` JSON tag are removed and you must use the correct `nodeName` JSON tag to reconfigure your node names.
      Show
      .NodeName string updated in JSON tag for BGPConfiguration parameter Before this update, the BGPConfiguration parameter `spec.frrNodeConfigurationSelector.nodename` had an inconsistency in its JSON tag where the NodeName string `json:"frrConfigurationNamespace,omitempty` was incorrect because `frrConfigurationNamespace` is a node name. With this update, the NodeName string in the JSON tag is correctly set as `json:"nodeName,omitempty"`. You can now configure the `frrNodeConfigurationSelector` by using the following spec: ----     frrNodeConfigurationSelector:     - nodeName: nodeA       nodeSelector:         matchLabels:           foo: bar ---- During an update to the fixed version, any node names that you previously specified by using the `frrConfigurationNamespace` JSON tag are removed and you must use the correct `nodeName` JSON tag to reconfigure your node names.
    • Bug Fix
    • Done
    • Important

      The BGPConfiguration parameter spec.frrNodeConfigurationSelector.nodename has inconsitency to its json tag:

          NodeName string `json:"frrConfigurationNamespace,omitempty"`

      and should be

          NodeName string `json:"nodeName,omitempty"`

       
      Right now you'd have to create a spec like:

          frrNodeConfigurationSelector:
    - frrConfigurationNamespace: nodeA
      nodeSelector:
        matchLabels:
          foo: bar

      where `frrConfigurationNamespace` is just wrong as it is a node name.
       

       

              rhn-support-mschuppe Martin Schuppert
              rhn-support-mschuppe Martin Schuppert
              rhos-dfg-pidone
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: