Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-14488

Improve TopologyRef Validation webhook

XMLWordPrintable

    • Icon: Epic Epic
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • openstack-operator
    • None
    • Improve TopologyRef Validation webhook
    • 10
    • False
    • Hide

      None

      Show
      None
    • False
    • Not Selected
    • Committed
    • In Progress
    • Proposed
    • ?
    • 50% To Do, 50% In Progress, 0% Done

      Goal:

      Based on the reviews [1] [2], we identified several issues in the validation webhook that can be addressed to enhance how we determine the validity of a TopologyRef.

      Although these reviews are part of the nova-operator, improving the validation webhook will require updates across the board, and stories will be added for each operator.

      With this update we expect that TopologyRef basePath is not resolved as part of the helper, but should be in the same code as the struct field referencing it.
      The webhook related envTests should give evidence of the path in the error message [4].

      [1]  https://github.com/openstack-k8s-operators/nova-operator/pull/924/files#r1969740248
      [2]  https://github.com/openstack-k8s-operators/nova-operator/pull/924/files#r1969728737
      [3] https://github.com/openstack-k8s-operators/openstack-operator/pull/1316/files#r1973104466
      [4] https://github.com/openstack-k8s-operators/nova-operator/pull/924/files#r1971735027

              fpantano@redhat.com Francesco Pantano
              fpantano@redhat.com Francesco Pantano
              rhos-dfg-ospk8s
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: