Description

Our OpenStackDataPlaneDeployment controller reconcile logic is difficult to follow, test and in some cases quite inefficient. Ideally, we should refactor this logic where possible to focus on creating a design that is intuitive for engineers to follow and contribute to. This will also ensure the code is testable in a more deliberate manner without relying on the resulting objects. Which allows for ease of troubleshooting and quickly identifying errors.

Objective

1. Eliminate unnecessary for loops over NodeSet items. While this may have minimal impact when a deployment contains one or two NodeSets, it could become and issue as the number of NodeSets in a deployment grows for larger environments.
2. Break up large blocks of code into dedicated methods or functions. Test those functions independently to a) ensure contributors can easily identify where their code is causing issues, and b) catch issues with logic assumptions earlier.