Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-13331

[upstream][fvt] Incorrect failure condition on the journal tests

XMLWordPrintable

    • 1
    • False
    • Hide

      None

      Show
      None
    • False
    • ?
    • None
    • Low

      The issue was identified in this review: https://github.com/infrawatch/feature-verification-tests/pull/181/files#r1927684348

      The issue is not related to any content added in the review, but was noticed and commented onduring the review.

       

      The failed_when requires that all the conditions be met in order to fail.

      The intent when writing was that all had to be met to pass, so any condition not met should lead to a failure.

      The failed_when should explicitly use `or` in a single list item, rather than providing a list of conditions.

       

      Two options present themselves.

      1. Change the failed_when to use `or` in a single list item
      2. Add a second task that uses the assert module, which requires all list items be true in order to pass, and provide it with the negatives of the fail conditions

      Related to: https://issues.redhat.com/browse/OSPRH-13139

              efoley@redhat.com Emma Foley
              efoley@redhat.com Emma Foley
              rhos-dfg-cloudops
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: