Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-12673

BZ#2327315 backup playbook are not clearning /var/tmp/rear.* but the default path is now /var/tmp which leaves stale files there

XMLWordPrintable

    • 5
    • False
    • False
    • Committed
    • Committed
    • Committed
    • None
    • Moderate

      backup playbook are not clearning /var/tmp/rear.* but the default path is now /var/tmp which leaves stale files each time a backup is taken. Here's a patch that should fix that :

      [dhill@knox backup_and_restore]$ git diff
      diff --git a/tripleo_ansible/roles/backup_and_restore/defaults/main.yml b/tripleo_ansible/roles/backup_and_restore/defaults/main.yml
      index 5110452b..ebd30b38 100644
      — a/tripleo_ansible/roles/backup_and_restore/defaults/main.yml
      +++ b/tripleo_ansible/roles/backup_and_restore/defaults/main.yml
      @@ -47,7 +47,7 @@ tripleo_backup_and_restore_clients_nets: ['192.168.24.0/24', '10.0.0.0/24', '172
      tripleo_backup_and_restore_shared_storage_subfolders: []
      tripleo_backup_and_restore_rear_simulate: false
      tripleo_backup_and_restore_using_uefi_bootloader: 0
      -tripleo_backup_and_restore_exclude_paths_common: ['/data/*', '/tmp/*', '{{ tripleo_backup_and_restore_shared_storage_folder }}/*']
      +tripleo_backup_and_restore_exclude_paths_common: ['/data/*', '/tmp/*', '/var/tmp/*', '{{ tripleo_backup_and_restore_shared_storage_folder }}/*']
      tripleo_backup_and_restore_exclude_paths_controller_non_bootstrapnode: false
      tripleo_backup_and_restore_exclude_paths_controller: ['/var/lib/mysql/*']
      tripleo_backup_and_restore_exclude_paths_compute: ['/var/lib/nova/instances/*']
      diff --git a/tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml b/tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml
      index c7ec32a7..51b489ac 100644
      — a/tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml
      +++ b/tripleo_ansible/roles/backup_and_restore/tasks/run_backup.yml
      @@ -83,6 +83,7 @@
      shell: |
      set -o pipefail
      rm -rf /tmp/rear.* || true
      + rm -rf /var/tmp/rear.* || true
      rm -rf /var/lib/rear/output/*
      failed_when: false
      tags:

              jbadiapa@redhat.com Juan Payno
              jira-bugzilla-migration RH Bugzilla Integration
              Archana Singh Archana Singh
              rhos-dfg-upgrades
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated: