Launchpad bug: https://bugs.launchpad.net/neutron/+bug/2084782

This bug is related to [1] and the mentioned bugs and patches in the commit message.

Context:

• ML2/OVN driver.
• Distributed floating IPs.

When a router has "mixed type networks" (tunnelled and not tunnelled networks), the VLAN/flat LRP should have the flag 'reside-on-redirect-chassis' to True. If the router has only VLAN/flat networks, the flag 'reside-on-redirect-chassis' should be False and 'redirect-type'='bridge'.

The patch [1] does not consider the router LRP addition/deletion. For example, if we initially add the VLAN/flat network to the router, the router won't have "mixed type networks". If we then add a tunnelled network, we don't update the VLAN/flat LRP. The same scenario happens when we remove a tunnelled LRP and the router has only VLAN/flat networks.

NOTE: [2] could be an alternative to centralizing all the provider networks traffic, but that could also lead to other problems. For example, QoS: the provider networks is no longer using the localnet port (physical device) but is tunnelled. The QoS rules applied on the physical interface won't affect this traffic.

[1]https://review.opendev.org/c/openstack/neutron/+/878450

[2]https://github.com/ovn-org/ovn/commit/87a29064