While working on a new functional test that checks that the operator doesn't recreate a nova keypair when it already exists, I noticed that it was deleting and reuploading a new keypair in the reconcile loop

uploadKeypair is called when there's a key in the configMap

https://github.com/openstack-k8s-operators/octavia-operator/blob/90ffa9a759ca587b9675d0082b7ce41f32838d87/pkg/octavia/amphora_ssh.go#L190

uploadKeypair detects an existing key, deletes it and uploads a new key

https://github.com/openstack-k8s-operators/octavia-operator/blob/90ffa9a759ca587b9675d0082b7ce41f32838d87/pkg/octavia/amphora_ssh.go#L143-L160

The test that detects it:

https://github.com/openstack-k8s-operators/octavia-operator/pull/387/files#diff-840635b6344846e7c2aa232a48576e3226b490d1b4627963c5fe0cf4dd3313ffR571-R574