Uploaded image for project: 'Red Hat OpenStack Services on OpenShift'
  1. Red Hat OpenStack Services on OpenShift
  2. OSPRH-10351

edpm_frr requires gather_facts enabled

XMLWordPrintable

    • Icon: Epic Epic
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • rhos-18.0 Feature Release 1 (Nov 2024)
    • edpm-ansible
    • None
    • Ensure EDPM FRR role can execute without relying on previously gathered facts
    • 4
    • False
    • Hide

      None

      Show
      None
    • False
    • ?
    • ?
    • ?
    • ?
    • 0% To Do, 0% In Progress, 100% Done

      This bug does not affect trunk code (18.0.2 candidates) yet, but it's affecting upstream main branch code.

      Dataplane deployment fails due to this:

       

      [zuul@controller-0 ~]$  oc -n openstack logs frr-edpm-deployment-compute-nodes-57qzb 
      Identity added: /runner/artifacts/frr-edpm-deployment-compute-nodes/ssh_key_data (cifmw_reproducer_key)
      [WARNING]: Invalid characters were found in group names but not replaced, use
      -vvvv to see details
      PLAY [Deploy EDPM FRR] *********************************************************
      TASK [osp.edpm.edpm_frr : Validating arguments against arg spec 'main' - The main entry point for the edpm_frr role.] ***
      fatal: [compute-fthyng6f-0]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'hostname'. 'dict object' has no attribute 'hostname'. 'dict object' has no attribute 'hostname'. 'dict object' has no attribute 'hostname'"}
      ...
      

       

       

      In a downstream job, that task doesn't fail and it is preceded by a "Gathering Facts".

      This change could have caused this bug:
      https://github.com/openstack-k8s-operators/edpm-ansible/commit/530ba9e4a598c104ddf873474579a71e517128db

       

      The error seems to happen when the frr role tries to obtain a value for `edpm_frr_hostname`:
      https://github.com/openstack-k8s-operators/edpm-ansible/blob/main/roles/edpm_frr/meta/argument_specs.yml#L145

            edpm_frr_hostname:
              default: '{{ ansible_facts[''hostname''] }}'

       

              rhn-support-bshephar Brendan Shephard
              eolivare Eduardo Olivares Toledo
              rhos-dfg-df
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: