XMLWordPrintable

    • Icon: Spike Spike
    • Resolution: Done
    • Icon: Minor Minor
    • rhos-18.0 FR 1 (Nov 2024)
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide

      I have added pre-commit hook to PR

      However, a lot of files require update due to linting/styling recommendations. I am afraid to merge all this just before a release. I am converting this Story to Spike as

      1) A lot of files needs update and everytime I run
      ```
      pre-commit run --show-diff-on-failure --color=always --all-files
      ```
      I get more and more files that require fixes.
      2) Timing is not perfect to push code just before a release

      Show
      I have added pre-commit hook to PR However, a lot of files require update due to linting/styling recommendations. I am afraid to merge all this just before a release. I am converting this Story to Spike as 1) A lot of files needs update and everytime I run ``` pre-commit run --show-diff-on-failure --color=always --all-files ``` I get more and more files that require fixes. 2) Timing is not perfect to push code just before a release

      As project grows it would be nice to have a CI to catch linting problems, bugs or even check the patch that it's actually works

      I started playing with CI as [1], thus I am opening this task

      [1] https://gitlab.cee.redhat.com/sgolovat/rhev-adoption-ci/-/blob/implement_ci/.gitlab-ci.yml?ref_type=heads

              rhn-engineering-sgolovat Sergii Golovatiuk
              rhn-engineering-sgolovat Sergii Golovatiuk
              Sergii Golovatiuk
              rhos-dfg-upgrades
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: