Uploaded image for project: 'OpenShift Java Client'
  1. OpenShift Java Client
  2. OSJC-20

openshift-java-client: correct alias-integration tests to add valid aliases

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 2.2.0
    • None
    • None
    • None

      openshift-java-client integration test against DEVENV started to fail when OpenShift changed validity rules for aliases:

      Tests in error:
        shouldAddAliasToApplication(com.openshift.internal.client.ApplicationResourceIntegrationTest): Could not request https://ec2-107-20-110-143.compute-1.amazonaws.com/broker/rest/domains/1370028343009/applications/1370028873585/events: null=Operation failed with exit code "105".Reason given: "Invalid Server Alias '1370029105965' specified"(..)
        shouldRemoveAliasOfApplication(com.openshift.internal.client.ApplicationResourceIntegrationTest): Could not request https://ec2-107-20-110-143.compute-1.amazonaws.com/broker/rest/domains/1370028343009/applications/1370028873585/events: null=Operation failed with exit code "105".Reason given: "Invalid Server Alias '1370029106182' specified"(..)
      

      In bug https://bugzilla.redhat.com/show_bug.cgi?id=968952 the OpenShift team changed the regex that validates aliases (see https://bugzilla.redhat.com/show_bug.cgi?id=968952#c4):

      " /\A[a-z0-9]+(-[a-z0-9]+)*(\.[a-z0-9]+(-[a-z0-9]+)*)+\z/"
      

      The openshift-java-client integration tests fail when adding aliases in the form of 13 numerical characters (ex. "1370029105965")
      Since we dont want to replicate the server logic we'll simply change the integration tests to add valid aliases and add another integration test that's expected to fail

              adietish@redhat.com André Dietisheim
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: