Uploaded image for project: 'OpenShift Java Client'
  1. OpenShift Java Client
  2. OSJC-11

openshift-java-client: remove workaround for https://bugzilla.redhat.com/show_bug.cgi?id=812046

    Details

    • Type: Enhancement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 2.4.0
    • Component/s: None
    • Labels:
      None

      Description

      In the latest implementations the OpenShift broker returns the embedded cartridges within the application as follows:

      
            "embedded":{
               "mongodb-2.2":{
                  "connection_url":"mongodb://$OPENSHIFT_MONGODB_DB_HOST:$OPENSHIFT_MONGODB_DB_PORT/",
                  "username":"admin",
                  "password":"NNxXMT1z8dVj",
                  "database_name":"springeap6",
                  "info":"Connection URL: mongodb://$OPENSHIFT_MONGODB_DB_HOST:$OPENSHIFT_MONGODB_DB_PORT/"
               }
            },
      

      Prior code was only returning the info property where we had to exctract the url via regex. The new broker is returning the connection_url which does not require any regex-treatment any more

      The code in openshift-java-client marks this workaround with a TODO:

      protected EmbeddedCartridgeResource(final String name, final String displayName, final String description, final CartridgeType type, String info, final Map<String, Link> links,
      	final Map<String, Message> messages, final ApplicationResource application) {
      	super(application.getService(), links, messages);
      	this.name = name;
      	this.displayName = displayName;
      	this.description = description;
      	this.type = type;
      	// TODO: fix this workaround once
      	// https://bugzilla.redhat.com/show_bug.cgi?id=812046 is fixed
      	this.url = extractUrl(info, messages);
      	this.application = application;
      }
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  adietish André Dietisheim
                  Reporter:
                  adietish André Dietisheim
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: