Uploaded image for project: 'OpenStack as Infra'
  1. OpenStack as Infra
  2. OSASINFRA-3953

GH-orc-529: Recovered panic in server tag reconciliation

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • ORC
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • Not Selected

      Originally posted on Github: https://github.com/k-orc/openstack-resource-controller/issues/529

      Problem description
      Seen today in my logs after I rebased my wbranch on main:
      2025-10-03T11:11:39+02:00 ERROR Observed a panic {"controller": "server", "controllerGroup": "openstack.k-orc.cloud", "controllerKind": "Server", "Server":

      {"name":"martin-test","namespace":"default"}

      , "namespace": "default", "name": "martin-test", "reconcileID": "64494bd7-f6db-4dce-9936-895d34583c05", "panic": "runtime err
      or: invalid memory address or nil pointer dereference", "panicGoValue": "\"invalid memory address or nil pointer dereference\"", "stacktrace": "goroutine 1181 [running]:\nk8s.io/apimachinery/pkg/util/runtime.logPanic(

      {0x272bad0, 0xc00081be90}, {0x1fd5360, 0x3b21cb0})\n\t/home/martin/go/pkg/mod/k8s.io/apimachinery@v0.32.9/pkg/util/runtime/
      runtime.go:107 +0xbc\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile.func1()\n\t/home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:108 +0x112\npanic({0x1fd5360?, 0x3b21cb0?})\n\t/home/martin/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.0.linux-amd64/sr
      c/runtime/panic.go:785 +0x132\ngithub.com/k-orc/openstack-resource-controller/v2/internal/controllers/server.serverActuator.GetResourceReconcilers(...)\n\t/home/martin/dev/openshift/openstack-resource-controller/internal/controllers/server/actuator.go:281\ngithub.com/k-orc/openstack-resource-controller/v2/internal/controllers/generic/reco
      nciler.(*Controller[...]).reconcileNormal(0x2760400, {0x272bad0, 0xc0007ad6e0}, {0x2762420, 0xc000b00180})\n\t/home/martin/dev/openshift/openstack-resource-controller/internal/controllers/generic/reconciler/controller.go:221 +0x702\ngithub.com/k-orc/openstack-resource-controller/v2/internal/controllers/generic/reconciler.(*Controller[...]
      ).Reconcile(0x2760400, {0x272bad0, 0xc00081be90}

      , {{

      {0xc00025ab30, 0x0?}

      ,

      {0xc00025ab20?, 0x172a1e5?}

      }})\n\t/home/martin/dev/openshift/openstack-resource-controller/internal/controllers/generic/reconciler/controller.go:131 +0x285\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile(0xc00081be00?,

      {0x272bad0 ?, 0xc00081be90?}

      , {{

      {0xc00025ab30?, 0x0?}

      ,

      {0xc00025ab20?, 0x0?}

      }})\n\t/home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:119 +0xbf\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler(0x2756200,

      {0x272bb08, 0xc00035b5e0}, {0xc00025ab30, 0x7}, {0xc 00025ab20, 0xb}, 0x0)\n\t/home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:334 +0x3ad\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem(0x2756200, {0x272bb08, 0xc00035b5e0}

      )\n\t/home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pk
      g/internal/controller/controller.go:294 +0x21e\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2()\n\t/home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:255 +0x85\ncreated by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).St
      art.func2 in goroutine 240\n\t/home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:251 +0x6b8\n"}
      runtime.sigpanic
      /home/martin/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.0.linux-amd64/src/runtime/signal_unix.go:900
      github.com/k-orc/openstack-resource-controller/v2/internal/controllers/server.serverActuator.GetResourceReconcilers
      /home/martin/dev/openshift/openstack-resource-controller/internal/controllers/server/actuator.go:281
      github.com/k-orc/openstack-resource-controller/v2/internal/controllers/generic/reconciler.(*Controller[...]).reconcileNormal
      /home/martin/dev/openshift/openstack-resource-controller/internal/controllers/generic/reconciler/controller.go:221
      github.com/k-orc/openstack-resource-controller/v2/internal/controllers/generic/reconciler.(*Controller[...]).Reconcile
      /home/martin/dev/openshift/openstack-resource-controller/internal/controllers/generic/reconciler/controller.go:131
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile
      /home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:119
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
      /home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:334
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
      /home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:294
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
      /home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:255
      2025-10-03T11:11:39+02:00 ERROR Reconciler error {"controller": "server", "controllerGroup": "openstack.k-orc.cloud", "controllerKind": "Server", "Server":

      {"name":"martin-test","namespace":"default"}

      , "namespace": "default", "name": "martin-test", "reconcileID": "64494bd7-f6db-4dce-9936-895d34583c05", "error": "panic: runt
      ime error: invalid memory address or nil pointer dereference [recovered]"}
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
      /home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:347
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
      /home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:294
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
      /home/martin/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.4/pkg/internal/controller/controller.go:255

      Most likely caused by #511.
      ORC version
      main
      Additional information
      No response
      Relevant log output

              Unassigned Unassigned
              maandre@redhat.com Martin André
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: