Uploaded image for project: 'Operator Runtime'
  1. Operator Runtime
  2. OPRUN-3673

Fix desired state behaviour in helm applier

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • Eevee OLM Sprint 265
    • None
    • None
    • None

      internal/applier/helm.go:getReleaseState() contained two if blocks that handled driver.ErrReleaseNotFound with the first one returning, which meant the second block would never run.

      Additionally, the first handler always returned a nil desiredState causing the only currently used Preflight validator (crdupgradesafety) and potentially others in the future to exit immediately because of not having anything to validate.

      This fix leaves only the second handler block in, which actually triggers a dry-run installation and is able to return a proper desiredState that any Preflight validation can work with. It also has the added benefit of potentially spotting any issues and exiting earlier in case the dry-run failed.

      Note: this bug ticket was retroactively added to Jira.

              rh-ee-azych Artur Zych (Inactive)
              rh-ee-azych Artur Zych (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: