Uploaded image for project: 'OpenJDK'
  1. OpenJDK
  2. OPENJDK-3647

check /tmp/jre/bin/java and /tmp/jre/lib/modules exist post-s2i build if JLINK is enabled

    • Icon: Feature Feature
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • None
    • container
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • OpenJDK Sprint 3, OpenJDK Sprint 4

          [OPENJDK-3647] check /tmp/jre/bin/java and /tmp/jre/lib/modules exist post-s2i build if JLINK is enabled

          Hi jmatsuok ,  I ended up fixing these as part of trying to make sure OPENJDK-3591 was correct. Rather than repeat work I've just pushed the fixes to a new PR.

          Jonathan Dowland added a comment - Hi jmatsuok ,  I ended up fixing these as part of trying to make sure OPENJDK-3591 was correct. Rather than repeat work I've just pushed the fixes to a new PR.

          I've re-opened this as the new test unfortunately does not work:

          • "and" in lower-case is not recognise by Behave
          • "test -d" fails for /tmp/jre/bin/java and /tmp/jre/lib/modules because they are files not directories

          I would suggest also testing each of those separately, e.g.

          And run bash -c "test -d /tmp/jre/bin/java && echo PASS" in container and immediately check its output for PASS 

          so that if one or the other fails in a test run we can identify which;

          also – could avoid needing a nested bash expression by using another test tool e.g.

          And run stat /tmp/jre/bin/java in container and immediately check its output for regular file 

          Jonathan Dowland added a comment - I've re-opened this as the new test unfortunately does not work: "and" in lower-case is not recognise by Behave "test -d" fails for /tmp/jre/bin/java and /tmp/jre/lib/modules because they are files not directories I would suggest also testing each of those separately, e.g. And run bash -c "test -d /tmp/jre/bin/java && echo PASS" in container and immediately check its output for PASS so that if one or the other fails in a test run we can identify which; also – could avoid needing a nested bash expression by using another test tool e.g. And run stat /tmp/jre/bin/java in container and immediately check its output for regular file

          Joshua Matsuoka added a comment - PR Open: https://github.com/rh-openjdk/redhat-openjdk-containers/pull/553

            jdowland@redhat.com Jonathan Dowland
            jdowland@redhat.com Jonathan Dowland
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: