Uploaded image for project: 'OpenJDK'
  1. OpenJDK
  2. OPENJDK-2686 Explore a three stage build for the JLink workflow
  3. OPENJDK-2894

Stage 1: add a guard check in Dockerfile for presence of jlink scripts

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • None
    • container_jlink
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • OPENJDK-2686 - Explore a three stage build for the JLink workflow

      Until jlink-dev is merged, it's easy to forget that the incoming ImageStream to Stage 1 needs to have the jlink integration scripts in them.

      Assuming you have a local builder image from the jlink-dev branch, it's possible to manually push that into an imageStream in OpenShift. something like:

      REGISTRY_AUTH_PREFERENCE=docker oc registry login
      docker tag ubi9/openjdk-17:1.18 default-route-openshift-image-registry.apps-crc.testing/jlink1/ubi9-openjdk-17:1.18
      docker push default-route-openshift-image-registry.apps-crc.testing/jlink1/ubi9-openjdk-17:1.18

      However, to catch the situation where the imageStream does not have the jlink scripts early, I think we should extend the stage 1 Dockerfile to perform a check for one of the jlink scripts (e.g. opt/jboss/container/java/jlink/preflight.sh) and fail the build if it isn't present. Nothing more complex than RUN test -f ... I think.

            jhuttana1@redhat.com Jayashree Huttanagoudar
            jdowland@redhat.com Jonathan Dowland
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: