Uploaded image for project: 'OpenJDK'
  1. OpenJDK
  2. OPENJDK-242

[JavaS2I] Maven args doesn't contain -Djkube.skip=true

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • Containers.1.10.GA
    • None
    • container
    • None
    • False
    • False
    • Undefined

      The current Maven s2i build includes -Dfabric8.skip=true [1] but not -Djkube.skip=true [2]. JKube is the newer replacement for the fabric8 suite of tools. I think we should leave the -Dfabric8.skip=true for now as lots of existing workloads most likely still use this. Without this, an application wanting to use java s2i using Maven will have it's build blow up unless they add the environment variable

      MAVEN_ARGS_APPEND=-Djkube.skip=true

      to their build config.

       

      [1] https://github.com/jboss-openshift/cct_module/blob/master/jboss/container/maven/default/artifacts/opt/jboss/container/maven/default/maven.sh#L48

      [2] https://www.eclipse.org/jkube/docs/openshift-maven-plugin#build-goal-configuration

            jdowland@redhat.com Jonathan Dowland
            eric.deandrea Eric Deandrea
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: