User Story:
As an OpenShift Engineer I want to review, and fix, the upgrade workflow which is failing on CI starting on 4.18 due (new?) restrictions while creating the "opct" MachineConfigPool - required by OPCT upgrade workflow for the dedicated node so that partners can validate upgrade workflow in 4.18->4.19. 4.17 (opct-main-4.17-platform-none-vsphere-upgrade) upgrade is working as expected..

Description:

CI job[ |https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-redhat-openshift-ecosystem-opct-main-4.18-platform-none-vsphere-upgrade/1898599812043902976][opct-main-4.18-platform-none-vsphere-upgrade|https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-redhat-openshift-ecosystem-opct-main-4.18-platform-none-vsphere-upgrade/1898599812043902976] is failing when setting up the "opct" MachineConfigPool:

time="2025-03-09T05:50:49Z" level=info msg="Setting up node ci-op-ril1y0yi-0e310-nw2jb-compute-1..."

The machineconfigpools "opct" is invalid: : ValidatingAdmissionPolicy 'custom-machine-config-pool-selector' with binding 'custom-machine-config-pool-selector-binding' denied request: All custom MachineConfigPools must inherit from the worker pool and must have a machineConfigSelector that matches for a 'machineconfiguration.openshift.io/role: worker' label
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-03-09T05:50:49Z"}

error: failed to execute wrapped command: exit status 1 
INFO[2025-03-09T05:50:50Z] Step platform-none-vsphere-upgrade-opct-pre-dedicated failed after 8s. 
INFO[2025-03-09T05:50:50Z] Step phase pre failed after 47m54s.    

Acceptance Criteria:

• Review what would be a valid setup to create MachineConfigPool required to opct upgrade workflow starting on OCP 4.18
• Test if the correct flow will work, not disrupting the test environment in the upgrade workflow
• Apply any fixes in OPCT project in:
  • Documentation
  • CLI references to the MachineConfigPool configuration

Other Information:
< Record anything else that may be helpful to someone else picking up the card >

issue created by splat-bot

created from thread: https://redhat-internal.slack.com/archives/C04HTQ7A7EX/p1741499739913789