-
Story
-
Resolution: Done
-
Undefined
-
None
-
None
-
2
-
False
-
None
-
False
-
0
-
Not Supported
-
ODC Sprint 227, ODC Sprint 228, ODC Sprint 229, ODC Sprint 230, ODC Sprint 231, ODC Sprint 232
Description
packages/dev-console/src/components/edit-deployment/EditDeployment.tsx is now also used for the creation flow, so the name is confusing.
The both URLs are defined in frontend/packages/dev-console/src/plugin.tsx, but doesn't match our common URLs.
For pinned resources, the Create and Edit Flows don't mark the nav item as active.
{ type: 'Page/Route', properties: { exact: true, path: ['/edit-deployment/ns/:ns', '/create-deployment/ns/:ns/~new/form'], loader: async () => ( await import( './components/edit-deployment/EditDeploymentPage' /* webpackChunkName: "dev-console-edit-deployment" */ ) ).default, }, },
Acceptance Criteria
- Rename edit-deployment folder to deployment ( or deployments ? )
- Rename EditDeployment* components to Deployment* (except EditDeployment.tsx for moment)
- Rename utils/create-deployment-* utils/edit-deployment-* to utils/deployment-*
- Change routes from /create-deployment/... /edit-deployment/... to
/k8s/ns/:ns/deployment/~new/form and
/k8s/ns/:ns/deployment/:name/form
/k8s/ns/:ns/deploymentconfigs/~new/form and
/k8s/ns/:ns/deploymentconfigs/:name/form - Convert the route from packages/dev-console/src/plugin.tsx to packages/dev-console/console-extensions.json
Additional Details:
- is duplicated by
-
ODC-6653 Rename folder and routes from edit-deployment to deployment as it also handles the create flow
- Closed
- links to