Uploaded image for project: 'OpenShift Dev Console'
  1. OpenShift Dev Console
  2. ODC-6246

Import from Devfile: Create fails when Devfile is not fetched earlier


    • False
    • False
    • 0
    • undefined
    • Not Supported
    • ODC Sprint 212
    • Low

      Description of problem:

      When the user tries to import a Devfile from sample (or another one) and the Devfile could not be cached the submit button is enabled anyway.

      After submitting the user receives this internal error:

      Cannot convert undefined or null to object

      As part of this bugfix we should also check if this form works with private repositories.

      Prerequisites (if any, like setup, operators/versions):


      Steps to Reproduce

      1. A way that you exceed rate limit (or block network traffic to github.com)
      2. Open developer console, add page, Import from Devfile
      3. Click Try sample (auto fills URL with https://github.com/redhat-developer/devfile-sample at the moment)
      4. Enter a component name (General > Name), this enables the Create button at the moment
      5. Press "Create"

      Actual results:

      Form shows an internal error:

      Cannot convert undefined or null to object

      Expected results:

      See different options here:

      1. Create button should not be enabled until the internal Devfile data are fetched
      2. The reason that the form could not be submitted must be shown somewhere. Maybe below the "Rate limit exeeded" warning?
      3. Or the warning should be shown as error and explain that that the Devfile need to be fetched to create the kubernetes resource
      4. Or automatically refetch the Devfile when the user presses "Create" to check it again. A retry button was another alternative.

      Reproducibility (Always/Intermittent/Only Once):

      Always when rate limit exeeded.

      But this rate limiting is hard to reproduce, but happen a lot of times in our e2e tests on CI server.

      Build Details:


      Additional info:


            divgupta Divyanshi Gupta
            cjerolim Christoph Jerolimov
            Sanket Pathak Sanket Pathak
            0 Vote for this issue
            3 Start watching this issue