Feature Overview (aka. Goal Summary)  

Introduce snapshots support for Azure File as GA. It was introduced as TP in 4.17

Goals (aka. expected user outcomes)

After introducing TP support in 4.17, the goal of this epic is to promote it GA. See background section for details

It should cover both SMB (default) and NFS. SMB is the priority.

Requirements (aka. Acceptance Criteria):

Should pass all the regular CSI snapshot tests. All limitations should be documented. Major issues that were uncovered in TP should be solved. 

Use Cases (Optional):

As an OCP on Azure user I want to perform snapshots of my PVC and be able to restore them as a new PVC.

Questions to Answer (Optional):

Confirm that limitation uncovered in TP are solved

Out of Scope

N/A

Background

We have support for other cloud providers CSI snapshots, we need to align capabilities in Azure with their File CSI. Upstream support has lagged.

In TP (4.17) we found two major issues which delayed the GA of this feature

• The issue where we could run out of space on the storage device holding azcopy plan and job files should be resolved now, the driver cleans up the jobs after each successful run: https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/2c440fef0e9aea251a5837171cf561543f0179f1/pkg/azurefile/controllerserver.go#L1228
• The main concern was the recovery from failed pod, which should be resolved now. Discussion: https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/1950#issuecomment-3191072196

Manual testing confirmed that these are now solved, we can proceed with productization and official QE.

Customer Considerations

User experience should be the same as other CSI drivers.

Documentation Considerations

Removed the TP statement, if there is any specific information to add, include it in the Azure File CSI driver doc. Any limitation should be documented.

Interoperability Considerations

Can be leveraged by ARO or OSD on Azure.