Uploaded image for project: 'OpenShift Cloud'
  1. OpenShift Cloud
  2. OCPCLOUD-3363

Manifests-gen: Revisit --protect-cluster-resource flag

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • None
    • None
    • None
    • None
    • None

      Not needed for CAPI GA

       

      Context: https://github.com/openshift/cluster-api/pull/259#discussion_r2759039924

       

      Some discussion to be had, do we want to: 

      • Make the flag fully qualified
      • change the flag to -protect-cluster-kind

       

      Steps:

      • Decide what we do with the flag
      • Update manifests-gen
      • Update operands (make files in each repo)

       

      Extra context: 

       

      I have an ulterior motive here, btw: I would very much like to see us push all provider-specific code and configuration into provider repos. Over time, I think this will enable the team to scale better, as well as giving platform teams more agency over their own changes. We still need interfaces, though, and this is one of the more important ones. So I do care about it, perhaps more than folks who didn't come from a platform team. This is also why I've been writing docs for it.

       
      Maybe make the flag explicitly Kind? And then it's obvious the casing and we don't expect more than one kind to be the same in a single repo I suspect
       
      My reason for preferring kind btw is that resource singular isn't something we normally see, so the casing looks off. Renaming the flag to include `-kind` should give an appropriate hint to the format expected

              Unassigned Unassigned
              rh-ee-tbarberb Theo Barber-Bany
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: