Background

The Machine half of this (for both MAPI and CAPI) already exists. We want the same for MachineSets across both MAPI and CAPI, this card tracks that.

We should be able to borrow the logic from the CAPI/MAPI Machine VAPs, but we will need two separate VAPs as we can only have one parameter kind  

When Machines and MachineSets are not authoritative, they should not be allowed to be modified apart from labels, annotations and the authoritative API related fields.

We may be able to implement this using ValidatingAdmissionPolicy. If the validation is too complex for this, we will then need to use a webhook to validate the updates.

https://kubernetes.io/docs/reference/access-authn-authz/validating-admission-policy/

Both VAP and Webhooks have access to the SubjectAccessReview information, which will tell us which user updated the resource. We only want to allow major updates to come from the sync controller service account.

Behaviours

• Reject updates to non-authoritative resources, except:
  • Labels and Annotations that are not material to operation
    • Are not kubernetes.io or openshift.io prefixed
    • Are not being modified to not match the Authoritative resource
    • Are not important for operation of Cluster API or Machine API
  • Updates to the .spec.authoritativeAPI
  • Updates that originate from the service account of the sync controller or migration controller

edit(theo): 

• Are not being modified to not match the Authoritative resource === Are being modified away from matching Authoritative

Steps

• Write VAP for Machine and MachineSet validation in CAPI

Stakeholders

• Cluster Infra

Definition of Done

• When a non authoritative Machine/MachineSet is updated, the request is rejected unless it comes from the sync controller service account

• Docs

• <Add docs requirements for this card>

• Testing

• <Explain testing that will be added>