Background

At present, any Machine that configures LoadBalancers in the AWS ProviderSpec will cause an error in the conversion.

We don't expect load balancers to be configured for workers, so for the most part this is ok.

For control plane machines, we need to explore the differences between MAPI and CAPI and figure out the path forward such that, even though the load balancer names aren't configured on the control plane machines anymore, that they are correctly configured and new control plane machines continue to be attached.

The load balancer configuration is now on the AWSCluster resource so some updates will need to be made to check that the content of the AWSCluster matches, and, will continue to function.

When converting from CAPI to MAPI, we should be able to copy the load balancer details across to the providerSpec.

May be relevant https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/3f3ce56102048a3c58937c3964feb2d3da826743/api/v1beta2/awscluster_types.go#L59-L69

Steps

• Based on the above, verify that we can configure specific load balancer names in the AWSCluster
• Work out how this will work for the conversion library (we may need to extend/change the interface for the conversion)
• Fix both the MAPI2CAPI and CAPI2MAPI versions of the conversion where they currently lack load balancer conversion
• Be sure to make sure LB conversion still errors for worker nodes.

Stakeholders

• Cluster Infra

Definition of Done

• Control plane machines are still added to the correct load balancers when created by CAPI

• Docs

• <Add docs requirements for this card>

• Testing

• <Explain testing that will be added>