Uploaded image for project: 'OpenShift Cloud'
  1. OpenShift Cloud
  2. OCPCLOUD-1894

CPMSO: WebHooks add warning for missing TargetPools on GCP


    • Icon: Story Story
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • CLOUD Sprint 241, CLOUD Sprint 242, CLOUD Sprint 245, CLOUD Sprint 246, CLOUD Sprint 247

      User Story

      As a user I'd like to be warned when I'm setting up a Control Plane Machine Set for my control plane machines on GCP and I don't have the necessary TargetPools requirement for it to work correctly.


      We previously had a validating webhook on the CPMSO for GCP that would check if the control plane machine provider config set on the CPMS did have TargetPools, otherwise it would error.

      This unfortunately collides with GCP Private clusters, see https://issues.redhat.com/browse/OCPBUGS-6760.

      As such we decided to remove the check until warnings are supported in controller-runtime.
      Once those land we can re-add the check and throw a warning in those situations, to still inform the user without disrupting normal operations where that's not an issue.

      See:  https://redhat-internal.slack.com/archives/C68TNFWA2/p1675105892589279.

      Webhook warnings available for 0.16.0 release of controller-runtime


      • <Add steps to complete this card if appropriate>


      • <Who is interested in this/where did they request this>

      Definition of Done

      • <Add items that need to be completed for this card>
      • Docs
      • <Add docs requirements for this card>
      • Testing
      • <Explain testing that will be added>

            rmanak@redhat.com Radek Manak
            ddonati@redhat.com Damiano Donati
            Zhaohua Sun Zhaohua Sun
            0 Vote for this issue
            4 Start watching this issue