Uploaded image for project: 'OpenShift Cloud'
  1. OpenShift Cloud
  2. OCPCLOUD-1701

Remove inherently ignored labels from cluster autoscaler

    XMLWordPrintable

Details

    • Epic
    • Resolution: Done
    • Normal
    • openshift-4.13
    • None
    • Remove inherently ignored labels from cluster autoscaler
    • False
    • None
    • False
    • Not Selected
    • To Do
    • OCPSTRAT-291 - OpenShift AutoScaler (Phase 2)
    • Impediment
    • OCPSTRAT-291OpenShift AutoScaler (Phase 2)
    • 100
    • 100% 100%
    • If Release Note Needed, Set a Value
    • Set a Value

    Description

      Epic Goal

      • Remove the labels that the cluster autoscaler has ingrained into its code to ignore when performing a balance similar node groups operation.
      • Add these ignored labels to the cluster-autoscaler-operator so that they are enabled through command line flags when the autoscaler is deployed on a specific platform.

      Why is this important?

      • The upstream cluster-api community has agreed that the autoscaler will not include any automatically ignored labels for balancing node groups. This has been decided for a few reasons: it creates a maintenance burden on updating the known labels in the autoscaler, and it has the possibility to create bad interactions where users of cloud provider A will not be able to use labels that cloud provider B ignores.
      • Adding these labels to the cluster-autoscaler-operator will add value to its operation given that it will become a repository of known labels on any platform where OpenShift runs with machine-api support.

      Scenarios

      1. ...

      Acceptance Criteria

      • CI - MUST be running successfully with tests automated
      • Release Technical Enablement - Provide necessary release enablement details and documents.
      • ...

      Dependencies (internal and external)

      1. Requires update to upstream kubernetes cluster autoscaler
      2. Upstream change will be brought into downstream during the kubernetes version update for that release cycle
      3. Requires update to cluster-autoscaler-operator to ensure that there are no regressions in current behavior

      Previous Work (Optional):

      1. discussion with upstream about this topic
      2. https://github.com/kubernetes/autoscaler/pull/4458
      3. https://github.com/kubernetes/autoscaler/pull/5110
      4. https://github.com/kubernetes/autoscaler/pull/5148

      Open questions::

      Done Checklist

      • CI - CI is running, tests are automated and merged.
      • Release Enablement <link to Feature Enablement Presentation>
      • DEV - Upstream code and tests merged: <link to meaningful PR or GitHub Issue>
      • DEV - Upstream documentation merged: <link to meaningful PR or GitHub Issue>
      • DEV - Downstream build attached to advisory: <link to errata>
      • QE - Test plans in Polarion: <link or reference to Polarion>
      • QE - Automated tests merged: <link or reference to automated tests>
      • DOC - Downstream documentation merged: <link to meaningful PR>

      Attachments

        1.
        Docs Tracker Sub-task Closed Undefined Unassigned
        2.
        PX Tracker Sub-task Closed Undefined Unassigned
        3.
        QE Tracker Sub-task Closed Undefined Zhaohua Sun
        4.
        TE Tracker Sub-task Closed Undefined Unassigned

        Activity

          People

            mimccune@redhat.com Michael McCune
            mimccune@redhat.com Michael McCune
            Zhaohua Sun Zhaohua Sun
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: