Uploaded image for project: 'OpenShift Cloud'
  1. OpenShift Cloud
  2. OCPCLOUD-1673

Add Control Plane Machine Set generator controller


    • Icon: Story Story
    • Resolution: Done
    • Icon: Major Major
    • None
    • None
    • 5
    • False
    • None
    • False
    • OCPPLAN-9749 - Control Plane Scaling and Recovery (IPI clusters only) - Phase 0
    • CLOUD Sprint 225, CLOUD Sprint 226


      We recently finished working on the CPMS main controller. We now need a way to generate the CPMS object for a cluster based on its current state.

      We want a new controller that based on the cluster state generates a CPMS object and creates it against the API of the cluster. The CPMS object that will be created will have the `.spec.state` field set to `Inactive`, meaning that the main CPMS controller won't do any modification to the cluster based on that configuration until the user has reviewed/modified it and activated it by setting it to `Active`.

      To catch changes in the cluster state the CPMS generator controller will keep watching the state and perform CPMS object regenerations checking if the object needs updating. If that's the case the generator will delete and recreate the CPMS object. This will constantly happen while the CPMS state is set to `Inactive`. As soon as the user activates it (sets `.spec.state` to `Active`). The generator controller will stop processing and its logic will become a no-op.

      For now the generator controller will only be able to generate config for AWS clusters.

      We should make sure to include envtest based testing to give us confidence when making changes to the code in the future.


      • Add the CPMS generator controller logic
      • Write up a suite of tests to validate the behaviour of the controller


      • Cluster Infra
      • Service Delivery

      Definition of Done

      • Test coverage for the tool is >80%
      • Docs
      • N/A
      • Testing
      • N/A

            ddonati@redhat.com Damiano Donati
            joelspeed Joel Speed
            Milind Yadav Milind Yadav
            0 Vote for this issue
            2 Start watching this issue